Results 1654 comments of Gabriel Scherer

My comment remains that if some of those `unreachable()` are in fact reachable in case of programming bugs by the user, then I would prefer something that fails cleanly than...

> Here too I think we could forget about these programming errors. I see no benefit to making our system less usable/debuggable in this way. (In particular I very much...

> Switching to trapping here would introduce a third useless branch. This is IMO an advantage of using unreachable and trap annotations independently. It is the job of the *compiler*...

I tried entering the following code in goldbolt: ```c enum caml_ba_layout { CAML_BA_C_LAYOUT = 0, /* Row major, indices start at 0 */ CAML_BA_FORTRAN_LAYOUT = 0x100, /* Column major, indices...

If I understand correctly, in C++ `unreachable()` already exists and means "undefined behavior", and *if CAML_INTERNALS is set* and you include caml/misc.h in your code then it gets redefined below...

Approved again. Thanks for the masterful history rewriting.

@AltGr, I'm looking at this again and this is very strange. Here is the command-line produced by legacy ocamlbuild (before your patch) (reindented for clarity): ``` touch algo/algo.mli if ocamlfind...

So the idea is as follows. When `foo.mli` does not exist, producing either `foo.cmo` or `foo.cmx` will produce `foo.cmi` at the same time. To avoid concurrency races on `foo.cmi` when...

@AltGr I cannot reproduce the issue with dose3 5.0.1. Which version should I use to be able to reproduce the issue?

Thanks for the report! Just a few questions for clarifications: - when you compare the multi-process and the multi-domain workflows, both are using the OCaml 5.2.1 runtime? - how many...