docker-keybox
docker-keybox copied to clipboard
garywiz
adding audit
The feature was easy to add. I just added it, tested it, pushed a new version, and made sure the version on Docker Hub is updated as well.
The new configuration variables are now listed in the docker-keybox README.
The reason I omitted it originally was the note on the KeyBox github page: "Auditing is disabled by default and is only a proof of concept." However, it seems harmless to try it, and you can enable or disable it as you see fit.
Hope this helps.
That works thank you! I also had to modify my run-docker-keybox.sh file since I am using persistant disks.
Cool, great it works. run-docker-keybox.sh is really just a template, so modifying it is sort of what I expected. I assume you saw that the default version detects whether or not you have a "docker-keybox-storage" directory automatically and will keep persistent things there automatically if it exists. However, I really do expect people will want to customize things to match their own storage requirements. If you have any suggestions, please let me know!
Perhaps just add a storage variable like your have for the audit and other keybox options and default to the current storage name. Then people can change it to what is best for them?
On Sep 20, 2015, at 7:32 PM, Gary Wisniewski [email protected] wrote:
Cool, great it works. run-docker-keybox.sh is really just a template, so modifying it is sort of what I expected. I assume you saw that the default version detects whether or not you have a "docker-keybox-storage" directory automatically and will keep persistent things there automatically if it exists. However, I really do expect people will want to customize things to match their own storage requirements. If you have any suggestions, please let me know!
— Reply to this email directly or view it on GitHub https://github.com/garywiz/docker-keybox/issues/1#issuecomment-141850673.