linux-router icon indicating copy to clipboard operation
linux-router copied to clipboard

Now MAC filter deny is supported. (Only accept was supported.)

Open zaibaq opened this issue 3 years ago • 2 comments

This is to support --mac-filter-deny after only --mac-filter-accept was supported.

Use: If you want to use deny acl, use the option --mac-filter-deny. Similarly for accept acl, use --mac-filter-accept. Obviously, you cannot use both options at the same time. If you want to set a specific path for the mac addresses file, whether you're using deny or accept, you need to set the option --mac-filter-file <MAC_ADDRESSES_FILE>.

zaibaq avatar Sep 23 '22 18:09 zaibaq

Any updates regarding this? @garywill

zaibaq avatar Oct 03 '22 18:10 zaibaq

Hi, @zaibaq . Thank you for sending PR to us.

Your commit has 300+ lines changes, which is too hard for us to review. Please make a freshnew commit (based on the latest commit in master branch) containing only the feature part. Ignore those blanks, exclude them from commit.

You can use some GUI tool to choose lines to put into a commit, like git gui, gitg, git-cola`

garywill avatar Oct 04 '22 00:10 garywill