Gary Hunt
Gary Hunt
@saghul would you consider this change to the package file? It's a bit lazy on my behalf, but will ensure that my future PRs include the updated .d.ts files. The...
Right - I've got a process for updating these branches and PRs - apologies for the number of them - but hey ho :-)
No probs - I've just added a script that runs does "tsc && npm run test" that does what I need :-)
That's the bulk of the PRs in place - take a quick look at my comment against the one https://github.com/jitsi/lib-jitsi-meet/pull/1915
The next steps are going to be much harder, and some will require clean-up of the js first
A question about public vs internal code... I feel like we could do with a definition of which parts of the code are part of it's public API (and therefore...
The _ works nicely and is equivalent for private - but I'm thinking more about internal (it's a C# term) that refers to parts of the project which are visible...
Yeah - that was what I was getting at - seems to be much harder in javascript due to the use of modules both internally and externally. On Mon, 28...
That sounds like a good plan - I'll adopt that and see how we get on On Mon, 28 Feb 2022 at 10:35, Saúl Ibarra Corretgé ***@***.***> wrote: > Hum....
Any thoughts on where we're going with this? I went through the codebase a week or so ago and created a .d.ts by hand (it didn't take that long) and...