Gary Gregory
Gary Gregory
@StefanOltmann Thank you for your PR. You'll need a unit test to avoid future regressions and prove this fixes something.
@StefanOltmann Sounds good to me, ty!
@StefanOltmann I don't see any new tests here.
@StefanOltmann Thanks for the update. We're glad to get help to improve it all 😃
> @garydgregory I have fixed the test first. As soon you pulled the change I will refresh this PR. See my comments in your other PR. To summarize, please provide...
A PR should include main and test changes, not one PR for test changes, and a different PR for main changes.
Still no unit test. I'm not sure how we can avoid a future regression without one. 😞
Hello @StefanOltmann I don't think I understand what you are saying here. What I see in this PR is: - the addition of a utility method to main and -...
A PR should include main and test changes, not one PR for test changes, and a different PR for main changes.
Hi @kinow Any thoughts?