uri-js icon indicating copy to clipboard operation
uri-js copied to clipboard

Create ES5+Modules dist

Open garycourt opened this issue 6 years ago • 3 comments

In order to support the modules property in package.json, an ES5 version of uri-js using ES6 Modules needs to be compiled.

garycourt avatar May 25 '18 22:05 garycourt

There will be much rejoicing. My create-react-app app started failing to build when I added a dependent of uri-js ....

murphyke avatar Jun 05 '18 20:06 murphyke

Use uri-js@^4.2.2 for the time being, as that version doesn't have the modules property in package.json.

garycourt avatar Jun 05 '18 20:06 garycourt

Thanks, I forgot that I had just started using package-lock.json, and I had assumed that my CI/CD build was using the latest version. It's working now, obviously.

murphyke avatar Jun 06 '18 13:06 murphyke