Gary Burgess

Throwing sounds good to me - an infinite loop is no better than an error, and at least throwing will slightly demystify what the actual problem is.

Adding these sounds good to me!

Ah yeah, they should definitely return `List`!

Yeah, I wondered if this one might be problematic. It can always go ignored if we decide it's not worth it :smile:

I'd like the `newtype` personally, as the name at least gives a bit of a semantic clue to the value's intention.

☝️ I like that (type-indexing the `Hash`). I don't really know enough to give an opinion on whether the lack of inlining for the instances is a noticeable expense or...

Yeah, seems so - `concat` is implemented with `bind` which isn't stack safe: https://github.com/purescript/purescript-lists/blob/68bce83550247f1bcaf2c160b01e6740f1f5d471/src/Data/List/Types.purs#L165-L167

There is a quickcheck style library with shrinking, although I'm not sure how up to date it is with the latest compiler and such: https://github.com/jacobstanley/purescript-jack

Seems reasonable to me!

Seems reasonable to me!