Gary Burgess

Results 326 comments of Gary Burgess

I think `Error` would have been a good choice here actually. I generally name things without use-case specific prefixes/suffixes if I assume/intend modules to be imported qualified... aside from the...

I'm not against renaming it, but to me that name is worse from a meaning point of view :smile: - this library is the `-argonaut` addition to `purescript-codec`, so I'd...

That's a good question. I think I felt there was still something missing regarding JSON objects in there. I just need to use it in anger and see what it's...

Why's that? Also, the `instructor` variable is undefined here, and I'm not sure what the `b` is for either.

I wonder if it'd be better to extend `JsonDecodeError` with a parse error possibility too, so the composition could be more natural. A few times I've done a codec like...

Another option might be to make `JsonDecodeError` polymorphic, adding a constructor case that can be used to extend the allowable errors - there are times I've wanted other things that...

I dunno, yeah, maybe the suggested `Either String JsonDecodeError` is the simplest way :smile:.

That definitely seems like something worth exploring, but yeah, I think the implementation might need to change a bit. It seems like `Codec` would need to use `State` rather than...

Sorry, I just re-read your proposed type for `JPropCodec` in the issue title and see I lectured you on a bunch of stuff you've already worked out. The answer is...