hid4java
hid4java copied to clipboard
gary-rowe
Improvements to MacOS builds
Note before merging: This PR contains commits from #115, but they can be refactored out once that branch is merged into develop.
Relevant commits:
- 1e2be9a - Add darwin-aarch64 to dockcross
- fba8f73 - Bump JNA to 5.8.0 (allows separate
.dylibfiles for separate architectures on MacOS) - 88c66e9 - Switch to JNA 5.8.0 darwin suffix
- 88c66e9 - Gracefully handle missing folders, files
- 408420c - Remove problematic calls to
make clean(Closes #122) - e40bdfe - Add hints for
SDKROOT,MACOSX_DEPLOYMENT_TARGET(Closes #120)
Related #108
Hi! I opened this issue a couple days ago and created a little patch to add the "non-exclusive device open mode" for mac os.
I feel like this would be a great addition to this PR!
It does require libhidapi > 0.12.0 though, and I don't think that is the version currently used in this PR.
I could not figure out where the version is actually coming from though?
Hi! I opened this issue a couple days ago and created a little patch to add the "non-exclusive device open mode" for mac os.
Thanks! Can you please open a separate PR for this patch?
I feel like this would be a great addition to this PR!
Since it modifies the default behavior I think it should be separate for better tracking, but it definitely improves the quality of life for MacOS users.
I haven't read the ~~PR~~ patch yet, but many applications will want to maintain exclusive access, so I would recommend (if not already) that the PR has an API toggle for this behavior.
It does require
libhidapi>0.12.0though, and I don't think that is the version currently used in this PR. I could not figure out where the version is actually coming from though?
AFAIR, the build system always uses the latest version from upstream.
I implemented a toggle and the default behaviour is the same as before :)
I build this on top of your PR but i just noticed you only changed the build anyway so there should be no issue creating a separate PR.