browser-serialport icon indicating copy to clipboard operation
browser-serialport copied to clipboard

Published 20 hours ago • verified publisher icon garrows

update deprecated API patterns in sync with serialport 4.x

Open noopkat opened this issue 8 years ago • 7 comments

👋 Hello!

I'm opening this pull request to sync up some API differences that have occured between browser-serialport and node-serialport.

For some background on why it'd be great to keep them in sync:

@monteslu opened this rad pull request on one of my libraries: https://github.com/noopkat/avrgirl-arduino/pull/78

I would love to merge it, however my library uses the latest version of node-serialport, so this would call the wrong things in browser-serialport when it's packaged up for web use.

Thanks for this awesome library - this is really helpful to a lot of folks in the nodebots community 💓

noopkat avatar Jul 17 '16 19:07 noopkat

👍

Also, these changes likely mean I'll be able to use avr109/leonardo on avrgirl from a browser :)

monteslu avatar Jul 21 '16 14:07 monteslu

This is the major change. 👍 to that. The other major one is in the constructer. We now always throw errors during construction. The callback is now called openCallback and given to .open if autoOpen is the boolean true.

reconbot avatar Jul 28 '16 13:07 reconbot

@reconbot let's get @noopkat 's fork into the nodebots org. I can help maintain it from there

monteslu avatar Sep 30 '18 16:09 monteslu

@reconbot or the serialport org. can't remember where we ended up on orgs after the j5 summit :)

monteslu avatar Sep 30 '18 16:09 monteslu

I don't want to use the nodebots org yet as I haven't identified all the people who have full control there. A lot of inactive accounts with full access to everything. I setup a governance model for SerialPort so until Nodebots is sorted, let's use that. 👍

On Sun, Sep 30, 2018, 11:05 AM Luis Montes [email protected] wrote:

@reconbot https://github.com/reconbot or the serialport org. can't remember where we ended up on orgs after the j5 summit :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/garrows/browser-serialport/pull/43#issuecomment-425731436, or mute the thread https://github.com/notifications/unsubscribe-auth/AABlbnMZEEbgVK_3kDJ8POCP5Ak8goOrks5ugOvTgaJpZM4JOSu1 .

reconbot avatar Sep 30 '18 16:09 reconbot

@garrows will initiate the transfer of this one to serialport, and we can merge this when it gets there

monteslu avatar Sep 30 '18 16:09 monteslu

@garrows this makes you serialport maintainer, you should have permission to transfer the repo

reconbot avatar Oct 01 '18 00:10 reconbot