denoify icon indicating copy to clipboard operation
denoify copied to clipboard

feat(config-file): provide support for config file

Open GervinFung opened this issue 2 years ago • 5 comments

This PR is to resolve the issues stated in #55

GervinFung avatar Sep 05 '22 16:09 GervinFung

Also it would be realy nice to write some doc for the available config on https://docs.denoify.land like I have done with https://docs.keycloakify.dev/build-options.
I sent you an invite for the GitBook by email.

garronej avatar Sep 11 '22 11:09 garronej

Also it would be realy nice to write some doc for the available config on https://docs.denoify.land like I have done with https://docs.keycloakify.dev/build-options. I sent you an invite for the GitBook by email.

Can you resend it to me? I dont think I have the invitation for the GitBook

GervinFung avatar Sep 11 '22 13:09 GervinFung

@GervinFung LGTM! Thanks for applying my suggesting and refactorying!

garronej avatar Sep 12 '22 15:09 garronej

@GervinFung LGTM! Thanks for applying my suggesting and refactorying!

Just to confirm that there is nothing left to resolve right? If that's the case, I will fix the merging issues and merge it if you are ok with it

GervinFung avatar Sep 12 '22 15:09 GervinFung

Just to confirm that there is nothing left to resolve right? If that's the case, I will fix the merging issues and merge it if you are ok with it

Yes alright, let's release in beta first to make sure nothing've been broken and until there is some documentation for it.

So just fix the conflict and update the package.json version to 1.2.0-beta.0, it will release a beta on NPM and github release.

garronej avatar Sep 12 '22 16:09 garronej