UniqueVectors.jl
UniqueVectors.jl copied to clipboard
Enable Aqua.jl quality assurance
https://github.com/JuliaTesting/Aqua.jl
Should not be merged until #18 is resolved.
Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:
Coverage data is based on head (
a8ca1df) compared to base (d63669d). Patch has no changes to coverable lines.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@
## master #19 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 114 112 -2
=========================================
- Hits 114 112 -2
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/delegate.jl | 100.00% <0.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
CI report: tests pass on all released versions of Julia, but fail on nightly (1.10-dev) and also 1.9 beta. From CI:
4 ambiguities found
Ambiguity #1
findall(p::Base.Fix2{typeof(in), <:UniqueVectors.AbstractUniqueVector}, a::AbstractArray) @ UniqueVectors ~/work/UniqueVectors.jl/UniqueVectors.jl/src/UniqueVectors.jl:89
findall(f::Function, A::AbstractArray{Bool}) @ Base array.jl:2424
Possible fix, define
findall(::Base.Fix2{typeof(in), <:UniqueVectors.AbstractUniqueVector}, ::AbstractArray{Bool})
Ambiguity #2
findall(p::F, x::Union{SparseArrays.AbstractCompressedVector{var"#s971", Ti}, SubArray{var"#s971", 1, <:SparseArrays.AbstractSparseMatrixCSC{var"#s971", Ti}, Tuple{Base.Slice{Base.OneTo{Int64}}, Int64}, false}, SubArray{var"#s971", 1, <:SparseArrays.AbstractSparseVector{var"#s971", Ti}, Tuple{Base.Slice{Base.OneTo{Int64}}}, false}} where var"#s971") where {Ti, F<:Function} @ SparseArrays /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.10/SparseArrays/src/sparsevector.jl:805
findall(p::Base.Fix2{typeof(in), <:UniqueVectors.AbstractUniqueVector}, a::AbstractArray) @ UniqueVectors ~/work/UniqueVectors.jl/UniqueVectors.jl/src/UniqueVectors.jl:89
Possible fix, define
findall(::Union{F, F}, ::Union{SubArray{T, 1, <:SparseArrays.AbstractSparseMatrixCSC{T, Ti}, Tuple{Base.Slice{Base.OneTo{Int64}}, Int64}, false} where T, SubArray{var"#s971", 1, <:SparseArrays.AbstractSparseMatrixCSC{var"#s971", Ti}, Tuple{Base.Slice{Base.OneTo{Int64}}, Int64}, false} where var"#s971", SubArray{T, 1, <:SparseArrays.AbstractSparseVector{T, Ti}, Tuple{Base.Slice{Base.OneTo{Int64}}}, false} where T, SubArray{var"#s971", 1, <:SparseArrays.AbstractSparseVector{var"#s971", Ti}, Tuple{Base.Slice{Base.OneTo{Int64}}}, false} where var"#s971", SparseArrays.AbstractCompressedVector{T, Ti} where T}) where {F<:(Base.Fix2{typeof(in), <:UniqueVectors.AbstractUniqueVector}), Ti, F<:(Base.Fix2{typeof(in), <:UniqueVectors.AbstractUniqueVector})}
Ambiguity #3
findall(p::Base.Fix2{typeof(in)}, x::Union{SparseArrays.AbstractCompressedVector{var"#s971", Ti}, SubArray{var"#s971", 1, <:SparseArrays.AbstractSparseMatrixCSC{var"#s971", Ti}, Tuple{Base.Slice{Base.OneTo{Int64}}, Int64}, false}, SubArray{var"#s971", 1, <:SparseArrays.AbstractSparseVector{var"#s971", Ti}, Tuple{Base.Slice{Base.OneTo{Int64}}}, false}} where var"#s971") where Ti @ SparseArrays /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.10/SparseArrays/src/sparsevector.jl:830
findall(p::Base.Fix2{typeof(in), <:UniqueVectors.AbstractUniqueVector}, a::AbstractArray) @ UniqueVectors ~/work/UniqueVectors.jl/UniqueVectors.jl/src/UniqueVectors.jl:89
Possible fix, define
findall(::Base.Fix2{typeof(in), <:UniqueVectors.AbstractUniqueVector}, ::Union{SubArray{T, 1, <:SparseArrays.AbstractSparseMatrixCSC{T, Ti}, Tuple{Base.Slice{Base.OneTo{Int64}}, Int64}, false} where T, SubArray{var"#s971", 1, <:SparseArrays.AbstractSparseMatrixCSC{var"#s971", Ti}, Tuple{Base.Slice{Base.OneTo{Int64}}, Int64}, false} where var"#s971", SubArray{T, 1, <:SparseArrays.AbstractSparseVector{T, Ti}, Tuple{Base.Slice{Base.OneTo{Int64}}}, false} where T, SubArray{var"#s971", 1, <:SparseArrays.AbstractSparseVector{var"#s971", Ti}, Tuple{Base.Slice{Base.OneTo{Int64}}}, false} where var"#s971", SparseArrays.AbstractCompressedVector{T, Ti} where T}) where Ti
Ambiguity #4
findall(p::Base.Fix2{typeof(in), <:UniqueVectors.AbstractUniqueVector}, a::AbstractArray) @ UniqueVectors ~/work/UniqueVectors.jl/UniqueVectors.jl/src/UniqueVectors.jl:89
findall(f::Base.Fix2{typeof(in)}, A::AbstractArray{Bool}) @ Base array.jl:2425
Possible fix, define
findall(::Base.Fix2{typeof(in), <:UniqueVectors.AbstractUniqueVector}, ::AbstractArray{Bool})
Method ambiguity: Test Failed at /home/runner/.julia/packages/Aqua/bqhPD/src/ambiguities.jl:117
hence the new solution in #23