BackstopJS icon indicating copy to clipboard operation
BackstopJS copied to clipboard

Change proposal, keep all reports

Open klodoma opened this issue 3 years ago • 4 comments

In the current situation the html_report contains always the latest report and the older reports are lost.

I propose to add a "flag" where the html_report folder gets a similar structure to the bitmaps_test folder (with timestamps as sub-folders) which contains then the actual reports.

This helps if one executes the test repeatedly and want to see the diffs.

Any thoughts against such a feature?

Screenshot_6

klodoma avatar Aug 09 '21 14:08 klodoma

@klodoma yes, I am supportive. Others have asked for this as well. It could be as simple as an operation which runs after the current reporting flow completes and copies all dependent assets into an additional html_report directory structure.

SideNote: I personally don't have a big problem with redundant assets floating around to ensure backwards compatibility e.g. duplicating (not moving) assets into directories in the html_report directory are fine with me -- but issues with asset sizes sometimes come up for others. That said, I would approach any concerns of cleaning up old/redundant file bloat as a separate housecleaning problem.

garris avatar Aug 10 '21 03:08 garris

@garris I agree with redundancy, this is not something one will always use.

We could add a flag like: keepReports: true or reportsHistory: true, I would go with the former.

klodoma avatar Aug 10 '21 09:08 klodoma

I like keepReports -- but maybe archiveReports is a little more accurate (cause we would literally be creating self-contained report archives.)

garris avatar Aug 11 '21 15:08 garris

Hello, everyone! Is this feature still available?

We're struggling with generating an HTML report that includes all timestamped directories and not simply the latest one.

We tried activating the flag introduced in the MR attached to this issue, but to no avail. The description of this issue, though, fit exactly our needs.

A colleague of mine left another comment in another issue with more context on what we're trying to achieve: https://github.com/garris/BackstopJS/issues/1265#issuecomment-1552890064

nicolasgasco avatar May 18 '23 15:05 nicolasgasco