Garrett LeSage

Results 776 comments of Garrett LeSage

This was marked as completed... but I don't see a PR. I'd like to track the changes, as this directly affects a big issue we've been struggling with Cockpit for...

Why would you want to use some JavaScript for something that's provided natively by CSS and is in all browsers now (container queries)? Using JavaScript for something like this that...

(Also, general "rule of thumb": Issues really shouldn't be closed until there's code merged into the codebase that actually solves the problem.)

Here's a quick codepen that demos media queries as I mentioned above (and we don't even change the min-width / max-width already in place in PatternFly): https://codepen.io/garrett/pen/jOobaaq Additionally, you can...

https://github.com/patternfly/patternfly/issues/1825 is an old issue about this topic. Specifically this comment states it was "recently" worked on in 2020 https://github.com/patternfly/patternfly/issues/1825#issuecomment-638405853: > Just revisiting this. In a recent PR, we added...

This is how it should look according to PatternFly guidelines: ![image](https://github.com/cockpit-project/cockpit-podman/assets/10246/bccc74ff-ede1-42fb-81e2-43a7b9ac9066) - Modal confirmation of destructive action: https://www.patternfly.org/components/modal/design-guidelines#confirm-a-destructive-action - Indeterminate all, nested list of checkboxes: https://www.patternfly.org/components/forms/checkbox/design-guidelines Additionally: 1. I removed...

Right, we'd either want to switch to a `TableComposable` directly in Podman or switch `ListingPanel` over to one.

Yeah, keep pods in groups. I see the pods also have headers; you can sort the containers within a pod too? I don't think mixing podless containers with those from...

Seeing only containers outside of pods and containers in pods should probably go into filtering, which we should improve anyway, instead of adding a tab based UI.

Well, I think ImageMagick is mainly used for the .ico file. We could disable the favicon building and include a pre-built one instead. I'm not sure if it is used...