Garrett LeSage

Results 776 comments of Garrett LeSage

Can we get this looked at again and merged soon, please? Thanks! :sparkles:

Thanks for the comparison screenshots! It's not the only one with extra space, for example: ![image](https://user-images.githubusercontent.com/10246/205094642-e8dcc306-fc2f-49a4-b3af-595fd8b154ff.png) And there's extra space here, too (also _above_ "these changes"; the differentiating space below...

Rebased & stacked more fixes on top. I couldn't find what I had done prior, but realized it was simpler than what I had done before, so I just fixed...

> All looks good to me, this one has a small minor issue, maybe not even dark theme related I think it's not dark theme related, but it's probably not...

> I think the release announcement needs a screenshot! Good point! We should probably take the screenshot using Cockpit Client, which has had dark mode for quite some time already....

I've included a heavily optimized GIF above. It's chonky, but will work everywhere and can be included with a standard `img` tag. Here's a webm: [darkmode2.webm](https://user-images.githubusercontent.com/10246/199786211-55afd5b6-6aab-44a5-bf4c-d135db8c1ebe.webm) Here's an MP4 https://user-images.githubusercontent.com/10246/199786008-9178cc82-4fcc-49ff-bfd6-80ef4629087b.mp4...

Rebased. Although, I think we need to rework our build system and rewrite the breakpoints at that level (by changing the magic pixel values.... and drop our custom stuff).

Rebased on main. It would be nice if someone could finally look at this please. This affects the selection modals in the overview page, where you can change the profiles...

> @garrett the language selection menu has with this a weird state with scroll for the menu and the modal. Is that expected? This is for the overview modals, not...