Garrett LeSage
Garrett LeSage
Checkboxes shouldn't have empty labels. Quick fix suggestion: Make an options group with all the checkboxes instead: | -- | -- Container | counter_(ehhh? what is this?)_ | Target container...
> the image run modal, which has two checkboxes without a label Ah, then the run model also needs updating (outside of this PR). Thanks for pointing it out! >...
I've made some mockups, where I went back on the destination group, as I realized if we split the add/replace action into its own toplevel element, then that means there...
The combobox for the destination host would be a list of known hosts (perhaps currently used), with an option to add more by typing. It would use [the PatternFly typeahead...
> Something like "Create new container" and "Restore into existing container" would better describe the actions. OK, sure. "Restore into existing container" does sound a little weird to me. Can...
Thoughts: - Do we need to have a copy and expand function? Can't we just use a simple monospaced font (that wraps)? I don't think copying the text is going...
I've made a simple commit that brings over Cockpit's change of dropping the gutter in mobile sizes, which should help ease the layout a little in mobile sizes, in PR...
Most of the changes I nitpicked about have been addressed in the commit I just pushed up. I didn't want to keep requesting changes and stalling this PR. I like...
Should we add a version? It _might_ be useful in the future. (Not sure what reason, but it still could possibly?) Of course, we should probably check based on feature...
It's for re-creating a container. We wouldn't block it, but if it was created by Cockpit or doesn't have specific command line flags, then it's safely recreateable within Cockpit. Otherwise,...