Garrett LeSage

Results 767 comments of Garrett LeSage

Breakpoints are separate from this problem. This problem is with `:root {}` PF varibles being imported several times. node_modules/@patternfly/patternfly/base/patternfly-variables.scss contains: ``` @import "../sass-utilities/all"; @import "variables"; ``` We actually want the...

> The SELinux page has a minimal set of imports, one of them is @use "page" which imports page.scss which imports @import "@patternfly/patternfly/components/Page/page.scss"; Probably due to rewriting breakpoint variables in...

> For that we have global-variables right? Exactly. It's only used when it's included (not used) and then a file comes after it. This is why there's so much breakpoint...

I'm wondering if we should move some of the CSS from overview to somewhere else. Marking this as a draft right now.

This could be a rounding error, where it's off by a pixel sometimes, as table cells are often computed based on the width of their content. It could also, in...

I wanted to convert some SVGs (from PatternFly) to a symbol library and found this repo. After figuring out how to get gulp working again and how to add subdirectory...

BTW: This could be used not just for us in Cockpit, with our nav outside of the iframe, but also for anyone using PatternFly without sidebar navigation whatsoever, regardless of...

@nicolethoen: I'm not sure how a React resize observer would help with breakpoints. We need the breakpoints for different sizes of screens in CSS (not really with resizing, although resizing...

Not stale; still affects Cockpit (and everything else using iframes).

I've brought up the problem a few times over the years (latest being this issue with a proposed solution)... Just asking if this is being considered, as it's a really...