next-seo
next-seo copied to clipboard
garmeeh
Fix default robots overriding
Description of Change(s):
Fixes #727.
dangerouslySetAllPagesToNoIndex in <DefaultSeo> had been having a priority over noindex: false in <NextSeo> of each page component. nofollow is also the same.
Also, the test case have expected wrong result. This PR fixes it.
@Monchi any chance of updating the branch? This fix would be great if could be merged some day.
@rolandtoth Sure. I've updated and published a new patched version. https://www.npmjs.com/package/next-seo-yuku-fork
Hey @Monchi, thank you for the contribution 🙏 😄
next-seo was just re-written for V5, would you mind double checking your change is expected and updating the conflict. Apologies about the delay.
@garmeeh Any news? I think @nyedidikeke's review is not a problem. Any other change requests are welcome.
when this PR will get merged ? I'm facing the same issue and currently on latest version of next-seo
@yukukotani merged this today and spent a bit of time looking through it. The tests are failing on it.
The tests were failing on your pull request due to unrelated package issues. I opened an up to date branch pull request here to allow CI to run and tests did fail: https://github.com/garmeeh/next-seo/pull/1194
While going through remaining pull requests, turns out #1062 had an almost identical change as yours. Tests ended passing on this pull request. I have released this change now. Thanks for all your effort on this and apologies on not so great attention on this one.
This has been released in v6 now