ToDoista icon indicating copy to clipboard operation
ToDoista copied to clipboard

Published 20 hours ago • verified publisher icon garimasingh128

Form is not working

Open kitarp29 opened this issue 4 years ago • 10 comments

On the create ToDo Log page the form that takes s username is not working. I can work on this issue if you assign it to me

kitarp29 avatar Dec 06 '20 04:12 kitarp29

@garimasingh128

kitarp29 avatar Dec 06 '20 07:12 kitarp29

@garimasingh128 i want to do this if u assigned me?

MuhammadTanveer94 avatar Dec 07 '20 07:12 MuhammadTanveer94

Hi @garimasingh128 kindly assign me this issue :)

Nishant2907 avatar Dec 10 '20 17:12 Nishant2907

Hi @garimasingh128 I cloned and went through the project. First of all KUDOS on writing such nice and well-formatted code. Coming to the topic at hand, On this page, the React component for Username is using a <select> tag that renders and displays data fetched from the DB. This will work when it fetches data from the DB and display the usernames to get selected.

I can either change this to an <input> tag and make the options function obsolete.

Or work on the DB side to make sure the data is fetched and rendered here.

Which one should I do???

In the case of Description:, it uses an <input> so can be used right now. image

kitarp29 avatar Dec 10 '20 17:12 kitarp29

The username basically will show up a drop down menu with all the registered users. You don't have to input them explicitly, like we do in description so I think the second option will be better.

garimasingh128 avatar Dec 15 '20 10:12 garimasingh128

I want to work on this issue

yashgautam9274 avatar Dec 22 '20 18:12 yashgautam9274

Has someone started to work on this or can I start?

tirlochanarora16 avatar Dec 25 '20 13:12 tirlochanarora16

I will not be working on this issue @garimasingh128. So If you want then reassign it some one

kitarp29 avatar Dec 25 '20 13:12 kitarp29

How to set up the local environment for testing the changes?

tirlochanarora16 avatar Dec 25 '20 17:12 tirlochanarora16

If the server is running, the user list is fetched and displayed properly. I think that was the intent of the author, so form will work in that case. If there are no users, then they should be redirected to create user page with alert saying "Please create user to create a log" or something like that.

I've got a PR related to this. @garimasingh128
Do check and let me know.

skanda1395 avatar Dec 22 '21 08:12 skanda1395