Replace deprecated apt::source parameters

[dpash]

A number of apt:source parameters were deprecated, and have now been removed. This commit migrates to replacements

• key_source is replaced with passing a hash to the key parameter.
• include_src is replaced with passing a hash to the include parameter.
• required_packages has been replaced with explicitly installing them, and adding a dependency between the package and the apt::source.

I'm not sure if the explicit package installation might cause an issue with other modules doing the same thing.

This will resolve #607

[dpash]

The replacement for required_packages comes from

https://tickets.puppetlabs.com/browse/MODULES-3323

[cdenneen]

@garethr any chance to get this merged?

[cdenneen]

@dpash Can you rebase to get tests to pass? @garethr metadata.json doesn't specify older puppetlabs-apt so this fails with changes merged in few weeks back by @hunner

[ColinHebert]

What's the status of this rebase? cc @dpash

[bittner]

Any chance to get this rebased, @dpash, to get the tests to pass?

@garethr Can we get this issue fixed, the changes merged and a new release issued? Please! That would be tremendously helpful.

[Jeoffreybauvin]

Any news about this PR ?

[bittner]

@Jeoffreybauvin You have to tweet to Puppetlabs (see the reaction on my tweet), this may get noticed. Otherwise there's little chance for getting attraction from the maintainers. Or try to open a support request at Puppetlabs?