Add new docker repos for Debian and Ubuntu

[drignoto]

I create new branch to update the new repositories of Docker CE called "add-new-docker-repos".

Changes:

• Add new repos.
• Rename package name.
• Modify Spec tests.

Results of Spec tests:

Finished in 3 minutes 11.9 seconds (files took 1.34 seconds to load)
1299 examples, 0 failures, 10 pending


Total resources:   88
Touched resources: 61
Resource coverage: 69.32%

Results of Lint tests:

%{path}:%{linenumber}:%{check}:%{KIND}:%{message}
%{path}:%{linenumber}:%{check}:%{KIND}:%{message}

Results of Syntax tests:

---> syntax:manifests
---> syntax:templates
---> syntax:hiera:yaml

I cannot exec Beaker tests, but i pass this changes in Debian Jessie and Ubuntu 16.04 platforms.

[drignoto]

I solve Lint error in params.pp

[drignoto]

I remove the PE requirement in metadata.json for the Travis CI error.

[onimsha]

Since now Docker has changed their repo, and package name, how can the puppet module handles the upgrade? I was reading through the commit but it seems only run-able on a fresh machine.

[drignoto]

@onimsha I use this changes in my dev environment with a docker 1.13 installed. Because the packages are called differently, the update is simpler since it automatically eliminates docker-engine and installs docker-ce. There's an example after the puppet agent:

# dpkg -l |grep docker
ii  docker-ce                         17.03.0~ce-0~debian-jessie           amd64        Docker: the open-source application container engine
rc  docker-engine                     1.13.1-0~debian-jessie               amd64        Docker: the open-source application container engine

[scotty-c]

@drignoto Could I just ask that you please squash your commit into a single commit, Also remove code that you have commented out. I will test this branch tomorrow for you.

Thanks for your work on this branch, it is greatly appreciated.

[drignoto]

Hi @scotty-c !! Can you help me? i don't know how squash my commits in this stage (pull request). I remove the commented code at final commit. Thank you so much!

[scotty-c]

@drignoto Here you go !!! https://github.com/ginatrapani/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit

Sorry I didn't get a chance to test this yesterday, I will do it today.

[drignoto]

@scotty-c I'm sorry, I tried to do the squash but I do not understand it because it does not unify it, and I do not have time at work to investigate. If you want I leave you the freedom to clone my changes, do the squash and upload your changes.

The reason is that I am evolving the module by needs in my work, and I lack time to adapt my changes to the system of contributions of the community.

I also have some new changes to the swarm mode, I have created a facter to extract the tokens and be able to use them as exported resources, and I have also created a new type / provider called docker_stack to handle docker-compose version 3.

I'm going to do a pull request with these changes, see if I can squash the commits before doing the pull request.

[scotty-c]

@drignoto No worries, I will have a look at this PR and squash the commits. In regards to the other work you have been doing, Please raise them in individual PR's per feature.

Thanks again for your efforts

[drignoto]

@scotty-c Ok ;) thank you so much!!

[dhollinger]

@scotty-c Any update on when this may be available? We're going to need it soon for our puppet infrastructure and I'd rather not have to maintain our own internal version of the docker module.

If help is needed, I could squash the commits myself

[scotty-c]

@dhollinger sorry for the delay on this. We have had a few other features etc we are trying to prioritise for a new release of the module like services and secrets. I will have a look at this issue again this week. Again sorry for the delay.

[dhollinger]

@scotty-c Just curious if this will be available anytime soon. We are going to need it within the next month or so.

[Morsicus]

It works great. But obviously we can't continue to have old docker version (docker-engine package) :(