garethr-docker icon indicating copy to clipboard operation
garethr-docker copied to clipboard

Published 20 hours ago • verified publisher icon garethr

gpg check optional

Open alvarolmedo opened this issue 8 years ago • 6 comments

alvarolmedo avatar Jan 17 '17 08:01 alvarolmedo

I've checked in my dev env that this patch works fine. What is the CI doing exactly?

alvarolmedo avatar Jan 18 '17 13:01 alvarolmedo

@alvarolmedo The issue with the tests is they are using strict variables, and package_source_check isn't always defined for all branches in params.pp. You'll need to define the variable in the other branches and set to undef.

Some more details about that here for reference https://docs.puppet.com/puppet/latest/lang_variables.html#unassigned-variables-and-strict-mode

garethr avatar Jan 19 '17 13:01 garethr

What did you mean with the rest of branches? I should do PRs in the rest of the branch of this repo?

alvarolmedo avatar Feb 13 '17 11:02 alvarolmedo

Hey @alvarolmedo. The branches are the case $::osfamily 'RedHat' specifically, and missing in the other osfamily elements. They must be defined in the base docker::params and set to undef.

An example is $storage_config_template.

gregohardy avatar Feb 22 '17 11:02 gregohardy

@alvarolmedo Is this PR still valid? As there has been no update on this since Feb.

scotty-c avatar Jun 05 '17 03:06 scotty-c

So sorry. I can't review the PR the last months. Please give me a pair of days to reply.

alvarolmedo avatar Sep 07 '17 13:09 alvarolmedo