Windows installer is missing version and icon

[auanasgheps]

Describe the bug Windows installer is missing version and icon, showing no icon and a fake version: 00.00.00.00

To Reproduce Install BackRest on Windows

Expected behavior Whilst the icon is only a nice to have, having the real version displayed enables the user to know which version is installed using Settings/Control Panel, like almost all applications do. Also, it will allow for submission to Windows Package Manager (winget)!

Screenshots

Platform Info

• OS and Architecture: Windows 10 x64
• Backrest Version: 00.00.00.00... joking, 1.5

Additional context Add any other context about the problem here.

[garethgeorge]

Hey, thanks for making an issue to help track this. Definitely something that needs fixing and I think I've seen a few other issues discussing getting this on winget, we should definitely make that possible. My bandwidth with other refactors has been a bit sparse to get to it.

Adding a few notes on what needs to happen to fix this:

What needs to happen here is plumbing the tag that the github actions workflow is running on into the .nsis script here.

I believe nsis variables are just env vars -- it may be as simple as fixing https://github.com/garethgeorge/backrest/blob/main/scripts/generate-installers.sh#L3-L20 to pass through an env variable to the docker container e.g. VERSION= ...

I think the VERSION can be determined correctly in the github actions workflow by using ${{ github.ref_name }}" as the reference.

[brokoler]

I recognized the same issue on Windows 11 at multiple locations, using backrest v1.6.1. The issue can be reproduced only via installing backrest v1.6.1 to any Windows system.

Desktop Icons:

Startmenu Icons:

[auanasgheps]

Finally! The issue is resolved for me. Thanks!