Gareth Bowen

Results 383 comments of Gareth Bowen

Amazing! Thanks for seeing this through. Any idea what changed since [this comment](https://github.com/medic/cht-core/issues/6537#issuecomment-1227885661)?

Ok. Closing this as already done. Please reopen if we've missed anything!

@ralfudx This is the [rate limiting PR](https://github.com/medic/cht-core/pull/8675) I was talking about in today's call. The idea is to stop attackers being able to have unlimited tries at finding a correct...

@ralfudx For testing this I would recommend using the docker helper to install the `6530-rate-limiting` docker image. This way you don't have to set up the whole dev environment (though...

@ralfudx Thanks for the quick turnaround! Just checking but that screenshot shows a 429 at the end - was that taken from one of the tests that passed or the...

@ralfudx Excellent find! You're absolutely right. I've now fixed that issue, cleaned up the code a lot, and rebased to get the latest test improvements. Would you mind running your...

Thanks @ralfudx ! Merged.

@lucidNTR Would you mind reviewing this again?

@rgraddy @gpetrov This is definitely a bug but nobody is assigned to look into it right now. Do you have some time to narrow it down? For example, a unit...