gardenlinux icon indicating copy to clipboard operation
gardenlinux copied to clipboard

Published 20 hours ago • verified publisher icon gardenlinux

Feature/1310 add test local and implement testing for oci feature

Open adaevitncar opened this issue 2 years ago • 1 comments

feature(pytest): Add local test for _oci-feature

How to categorize this PR?

/kind test /area os /os garden-linux

Which issue(s) this PR fixes: Fixes #1310

adaevitncar avatar Oct 07 '22 14:10 adaevitncar

@adaevitncar Thank you for your contribution.

gardener-robot avatar Oct 07 '22 14:10 gardener-robot

@gyptazy You have pull request review open invite, please check

gardener-robot avatar Nov 25 '22 03:11 gardener-robot

@nanory the technical implementation of the new flag feature _oci has already been added and merged. As discussed, the handling for tests using the new fixture for local tests should be rewritten. Maybe we just close this PR and link it as a reference. It's in your decision how to handle this one.

gyptazy avatar Nov 25 '22 07:11 gyptazy

Hey @adaevitncar,

thanks for your effort and this PR. Unfortunately, the local fixture might be added in a slightly different way. As a result, I created https://github.com/gardenlinux/gardenlinux/issues/1437 and https://github.com/gardenlinux/gardenlinux/issues/1438.

Thanks, gyptazy

gyptazy avatar Nov 25 '22 09:11 gyptazy

After discussing this in our last meeting, I will reactivate this PR and merge it. Although, there will be a change in future, this platform and test can already be used now.

nanory avatar Dec 01 '22 08:12 nanory