oidc-webhook-authenticator icon indicating copy to clipboard operation
oidc-webhook-authenticator copied to clipboard

Solves runtime deployment issue at the helm chart. `hostNetwork` was not set.

Open angelbarrera92 opened this issue 1 year ago • 4 comments

What this PR does / why we need it:

I am testing the chart locally (using kind). And I found the deployment didn't expose the port as a host port. This is required to let the api-server reach this pod to authenticate requests.

I guess this was forgotten as the deployment available under config/samples have it: https://github.com/gardener/oidc-webhook-authenticator/blob/master/config/samples/deployment.yaml#L90

Which issue(s) this PR fixes: Not opened yet, i can open one if it is required.

Special notes for your reviewer: Im writing some docs to demonstrate how to make it working on a kind (locally) k8s cluster. Let me know if you want to publish it somewhere :)

Release note:

Solves runtime deployment issue at the helm chart. `hostNetwork` was not set.

angelbarrera92 avatar May 16 '23 16:05 angelbarrera92

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 16 '23 16:05 CLAassistant

@angelbarrera92 Thank you for your contribution.

gardener-robot avatar May 16 '23 16:05 gardener-robot

Thank you @angelbarrera92 for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

gardener-robot-ci-3 avatar May 16 '23 16:05 gardener-robot-ci-3

@angelbarrera92 thanks for opening this PR, however sharing the host network is something that we do not want for a productive scenario. I opened a PR that will allow setting the clusterIP through the helm charts. This will allow the kube-apiserver to directly call the service via its IP if that is required, i.e. OWA is deployed in the same k8s cluster and the kube-apiserver cannot use in-cluster dns.

dimityrmirchev avatar May 18 '23 12:05 dimityrmirchev