machine-controller-manager icon indicating copy to clipboard operation
machine-controller-manager copied to clipboard

Published 20 hours ago • verified publisher icon gardener

Satisfy linter

Open majst01 opened this issue 3 years ago • 3 comments

What this PR does / why we need it:

First round of fixes identified by running golangci-lint as proposed in #655

Depends on #655

Special notes for your reviewer:

Every commit is fixing one specific group of linter findings:

  • remove unused variables and funcs
  • remove unused func params
  • fix missing errcheck and potential nil pointer access
  • replace deprecated discoveryclient func

Issues in cloud provider specific code are left untouched because they are removed in #653

Release note:

fix first round of linter findings

majst01 avatar Nov 12 '21 09:11 majst01

@majst01 Thank you for your contribution.

gardener-robot avatar Nov 12 '21 09:11 gardener-robot

Thank you @majst01 for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

gardener-robot-ci-3 avatar Nov 12 '21 09:11 gardener-robot-ci-3

@majst01 You need rebase this pull request with latest master branch. Please check.

gardener-robot avatar Mar 22 '22 11:03 gardener-robot