Review implementation of `syncMachinesNodeTemplates` function

Open ggaurav10 opened this issue 6 years ago • 1 comments

In syncMachinesNodeTemplates function, the copyMachineSetNodeTemplatesToMachines function updates the machine object directly in the cache (without deepcopy).

Ideally we should be using updateMachineWithRetries function to update the node template into the machine, which is currently a loop.

Sep 13 '19 06:09 ggaurav10

Also, this, this and this comments are not valid for MCM. These comments seem to be taken directly from replicaset controller

Sep 17 '19 05:09 ggaurav10