machine-controller-manager icon indicating copy to clipboard operation
machine-controller-manager copied to clipboard

Published 20 hours ago • verified publisher icon gardener

Improvements for MCM

Open prashanth26 opened this issue 5 years ago • 2 comments

Issue

There are several optimizations identified for MCM to make it run better.

Solution

  • [ ] Eliminate all infinite for loops
  • [ ] Tag/mark machines while creation to identify each of them uniquely
  • [ ] Get rid of any GET calls before making UPDATES
  • [x] Don't process on updated objects
  • [ ] Safety controller to be re-written with an event-based mechanism
  • [ ] Use pointers to struct. There is far too much implicit struct copying going on especially in range for loops.

Credits: @mvladev

prashanth26 avatar Jul 04 '19 05:07 prashanth26

  • [ ] Use pointers to struct. There is far too much implicit struct copying going on especially in range for loops.

amshuman-kr avatar Jul 04 '19 06:07 amshuman-kr

Things are getting better with https://github.com/gardener/machine-controller-manager/pull/460. However, will keep this issue open to tracking exact improvements.

prashanth26 avatar Aug 13 '20 20:08 prashanth26

/close #724 An umbrella issue for tracking all MCM refactoring.

himanshu-kun avatar Feb 21 '23 06:02 himanshu-kun