gardener
gardener copied to clipboard
gardener
fix(dnsrecord): reconcile dnsrecords when changing their spec
How to categorize this PR?
/area control-plane /kind bug
What this PR does / why we need it: Since https://github.com/gardener/gardener/pull/5531, the DNSRecord is only annotated with gardener.cloud/operation=reconcile if the shoot.gardener.cloud/tasks annotation contains deployDNSRecord*. This in turn is only done during maintenance in order to limit the number of API calls made to the DNS provider.
If the DNSRecord object is not annotated with gardener.cloud/operation=reconcile, the DNSRecord controller will not act on it, even if the spec has changed.
Which issue(s) this PR fixes: Fixes #6463
Special notes for your reviewer:
Release note:
Fixed a bug where the Shoot reconciliation could get stuck due to `DNSRecords` not being reconciled.
Hi @nschad. Thanks for your PR.
I'm waiting for a gardener member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
![gardener-prow[bot] avatar](https://avatars.githubusercontent.com/in/154614?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: timebertt
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [timebertt]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Alright finally had some time to test the changes. Observed Generation was bumped to 2 without manual intervention. Migration went smoothly.
Thank you! @timebertt
/hold cancel
@timebertt: new pull request created: #6518
In response to this:
/cherrypick release-v1.53
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@timebertt: new pull request created: #6519
In response to this:
/cherrypick release-v1.52
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@timebertt: new pull request created: #6520
In response to this:
/cherrypick release-v1.51
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.