gardener icon indicating copy to clipboard operation
gardener copied to clipboard

Cleanup CloudProfile docker migration and Add Validation MachineImageVersion CRI

Open acumino opened this issue 3 years ago • 3 comments

How to categorize this PR?

/area control-plane /kind cleanup

What this PR does / why we need it: This PR adds validation for the CloudProfile MachineImageVersion CRI field. Now spec.machineImages[].versions[].cri in CloudProfile can't be set to nil. Also docker is added by default in cri. This defaulting of docker in cri can be removed after completion of https://github.com/gardener/gardener/issues/4673.

Which issue(s) this PR fixes: Fixes https://github.com/gardener/gardener/issues/6375

Special notes for your reviewer:

Release note:

NONE

acumino avatar Aug 12 '22 08:08 acumino

/test pull-gardener-e2e-kind

acumino avatar Aug 12 '22 11:08 acumino

/assign

timebertt avatar Aug 15 '22 08:08 timebertt

@acumino: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-apidiff 90e7a1980c2d190898d52e0d77be8fd835fded5c link false /test pull-gardener-apidiff

Full PR test history. Your PR dashboard. Command help for this repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

gardener-prow[bot] avatar Aug 16 '22 07:08 gardener-prow[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timebertt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

gardener-prow[bot] avatar Aug 16 '22 07:08 gardener-prow[bot]