gardener icon indicating copy to clipboard operation
gardener copied to clipboard

Add labels to `DNSRecord`s

Open hown3d opened this issue 1 month ago • 8 comments

How to categorize this PR?

/area usability /kind enhancement

What this PR does / why we need it: Adds labels to DNSRecords created for each shoot. This allows to use label selectors to only get the DNSRecords that are used for the Kubernetes API server.

Release note:

gardenlet now adds labels for `DNSRecord` resources created for `Shoot` control planes. This allows using label selectors to target `DNSRecord`s used for `Shoot` control plane components.

hown3d avatar Nov 13 '25 10:11 hown3d

Hi @hown3d. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

gardener-prow[bot] avatar Nov 13 '25 10:11 gardener-prow[bot]

/ok-to-test

rfranzke avatar Nov 14 '25 16:11 rfranzke

For the sake of completeness, should we also add a label to the ingress record (ref)?

I agree, added the labels on that record too.

hown3d avatar Nov 17 '25 12:11 hown3d

Test Integration ResourceManager NodeAgentAuthorizer Suite: [BeforeSuite]

FAILED] Expected success, but got an error:
    <*net.OpError | 0xc00089a2d0>: 
    listen tcp 127.0.0.1:32853: bind: address already in use
    {
        Op: "listen",
        Net: "tcp",
        Source: nil,
        Addr: <*net.TCPAddr | 0xc000d86390>{
            IP: [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 255, 255, 127, 0, 0, 1],
            Port: 32853,
            Zone: "",
        },
        Err: <*os.SyscallError | 0xc000894520>{
            Syscall: "bind",
            Err: <syscall.Errno>0x62,
        },
    }
In [BeforeSuite] at: /home/prow/go/src/github.com/gardener/gardener/test/integration/resourcemanager/nodeagentauthorizer/nodeagentauthorizer_suite_test.go:250 @ 11/17/25 12:54:52.972

Test Integration Gardenlet BackupEntry Suite: [It] BackupEntry controller tests migrate should set the BackupEntry status as Succeeded if the extension BackupEntry is migrated successfully

[FAILED] Expected success, but got an error:
    <*errors.StatusError | 0xc004e2c1e0>: 
    Internal error occurred: backupbucket.core.gardener.cloud "foo-czl6c" not found
    {
        ErrStatus: {
            TypeMeta: {Kind: "", APIVersion: ""},
            ListMeta: {
                SelfLink: "",
                ResourceVersion: "",
                Continue: "",
                RemainingItemCount: nil,
            },
            Status: "Failure",
            Message: "Internal error occurred: backupbucket.core.gardener.cloud \"foo-czl6c\" not found",
            Reason: "InternalError",
            Details: {
                Name: "",
                Group: "",
                Kind: "",
                UID: "",
                Causes: [
                    {
                        Type: "",
                        Message: "backupbucket.core.gardener.cloud \"foo-czl6c\" not found",
                        Field: "",
                    },
                ],
                RetryAfterSeconds: 0,
            },
            Code: 500,
        },
    }
In [JustBeforeEach] at: /home/prow/go/src/github.com/gardener/gardener/test/integration/gardenlet/backupentry/backupentry_test.go:314 @ 11/17/25 12:53:29.689

/test pull-gardener-integration

marc1404 avatar Nov 18 '25 10:11 marc1404

/test pull-gardener-e2e-kind-gardenadm

timuthy avatar Nov 24 '25 08:11 timuthy

/retest

hown3d avatar Dec 08 '25 10:12 hown3d

/assign

ialidzhikov avatar Dec 09 '25 06:12 ialidzhikov

@hown3d , I pushed fc7f0017a584c55d43c581b9f25ca3c5ccf8b593 to fix the failing unit test.

ialidzhikov avatar Dec 16 '25 12:12 ialidzhikov

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov, timuthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [ialidzhikov,timuthy]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

gardener-prow[bot] avatar Dec 16 '25 12:12 gardener-prow[bot]

LGTM label has been added.

Git tree hash: 65227c5195874f4609b73a0a4d2bccac69fae24e

gardener-prow[bot] avatar Dec 16 '25 12:12 gardener-prow[bot]

/test pull-gardener-e2e-kind-gardenadm

ialidzhikov avatar Dec 16 '25 13:12 ialidzhikov