gardener
Forbid setting the `Shoot`'s `.spec.kubernetes.kubeControllerManager.podEvictionTimeout` field for Kubernetes versions >= 1.33
How to categorize this PR?
/area control-plane /kind cleanup
What this PR does / why we need it:
This PR forbids users to set the previously deprecated .spec.kubernetes.kubeControllerManager.podEvictionTimeout shoot field for Kubernetes versions >= 1.33. In this way, once support for Kubernetes 1.32 is dropped, the field can be safely removed from the shoot spec.
Shoot owners should already be relying on the .spec.kubernetes.kubeAPIServer.defaultNotReadyTolerationSeconds and .spec.kubernetes.kubeAPIServer.defaultUnreachableTolerationSeconds fields, instead of the deprecated one as it has essentially been a no-op since k8s 1.13.
Which issue(s) this PR fixes: Part of https://github.com/gardener/gardener/issues/11933 (more concretely: https://github.com/gardener/gardener/issues/11933#issuecomment-2958527635)
Special notes for your reviewer: /cc @shafeeqes @RadaBDimitrova @Kostov6 @ialidzhikov
Release note:
The `.spec.kubernetes.kubeControllerManager.podEvictionTimeout` field in the `Shoot` API is forbidden to be set for Kubernetes versions >= 1.33 and will be removed after support for Kubernetes 1.32 is dropped.
@plkokanov: GitHub didn't allow me to request PR reviews from the following users: RadaBDimitrova.
Note that only gardener members and repo collaborators can review this PR, and authors cannot review their own PRs.
In response to this:
How to categorize this PR?
/area control-plane /kind cleanup
What this PR does / why we need it: This PR forbids users to set the previously deprecated
.spec.kubernetes.kubeControllerManager.podEvictionTimeoutshoot field for Kubernetes versions >= 1.33. In this way, once support for Kubernetes 1.32 is dropped, the field can be safely removed from the shoot spec. Shoot owners should already be relying on the.spec.kubernetes.kubeAPIServer.defaultNotReadyTolerationSecondsand.spec.kubernetes.kubeAPIServer.defaultUnreachableTolerationSecondsfields, instead of the deprecated one as it has essentially been a no-op since k8s 1.13.Which issue(s) this PR fixes: Part of https://github.com/gardener/gardener/issues/11933 (more concretely: https://github.com/gardener/gardener/issues/11933#issuecomment-2958527635)
Special notes for your reviewer: /cc @shafeeqes @RadaBDimitrova @Kostov6 @ialidzhikov
Release note:
The `.spec.kubernetes.kubeControllerManager.podEvictionTimeout` field in the `Shoot` API is forbidden to be set for Kubernetes versions >= 1.33 and will be removed after support for Kubernetes 1.32 is dropped.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
![gardener-prow[bot] avatar](https://avatars.githubusercontent.com/in/154614?v=4 "Published by a pub.dev verified publisher"){kind=small}
@ialidzhikov: GitHub didn't allow me to assign the following users: RadaBDimitrova.
Note that only gardener members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide
In response to this:
/assign @RadaBDimitrova @Kostov6 @ialidzhikov
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
LGTM label has been added.
LGTM label has been added.
LGTM label has been added.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ialidzhikov
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [ialidzhikov]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment