gardener-extension-provider-openstack
gardener-extension-provider-openstack copied to clipboard
gardener
Use existing subnet in shoot creation
How to categorize this PR? /area networking /kind enhancement /kind api-change /platform openstack
What this PR does / why we need it: Adds the possibility to specify an already existing openstack subnet in the shoot creation.
Specifying existing networks and routers is already possible. This PR adds support for the following use-cases:
- already existing network & subnet - router (including interface to subnet) created by extension
- already existing network, subnet & router - router interface to subnet must be manually created
Release note:
Allow usage of existing subnet in shoot creation
Thank you @Kumm-Kai for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.
@Kumm-Kai can you provide some examples of use-cases for this feature ?
Usually BYO-"thing" is a solution to the lack of enough control over the properties of the object or in some requests are about connectivity to "special subnets" which can be solved with other ways e.g. providing additional NICs to VMs and so on. I would like to understand what was missing in the first place.
@Kumm-Kai can you provide some examples of use-cases for this feature ?
Usually BYO-"thing" is a solution to the lack of enough control over the properties of the object or in some requests are about connectivity to "special subnets" which can be solved with other ways e.g. providing additional NICs to VMs and so on. I would like to understand what was missing in the first place.
Our use case is that we will get predefined networks, subnets & routers that are created & managed outside of gardener, allowing users to connect multiple cloud resources together in a direct routable way. You're correct that one could somehow achieve this by adding additional NICs to the VMs, but I would argue that it's easier to add support for existing subnets as we already have support for both existing networks & routers.
@Kumm-Kai You need rebase this pull request with latest master branch. Please check.
The "use existing subnet" feature is now implemented for both terraform and the infraflow.
Additional integration tests are added.
Validation for both API and configvalidator is also included.
Please take a look 🙂
Closing this pr in favour of https://github.com/gardener/gardener-extension-provider-openstack/pull/780 which is a continuation of the work from @Kumm-Kai for this PR.