gardener-extension-provider-aws icon indicating copy to clipboard operation
gardener-extension-provider-aws copied to clipboard

Published 20 hours ago • verified publisher icon gardener

Inserts `Architecture` from worker to machineclass

Open sssash18 opened this issue 1 year ago • 3 comments

How to categorize this PR?

/area control-plane /kind enhancement /platform aws

What this PR does / why we need it: This PR takes the architecture field from worker and then inserts it in the machine class Which issue(s) this PR fixes: Fixes Part of #https://github.com/gardener/autoscaler/issues/122

Special notes for your reviewer:

Release note:

Inserts `architecture` from worker to the machine class

sssash18 avatar Jan 09 '24 07:01 sssash18

@sssash18 Labels area/todo, kind/todo do not exist.

gardener-robot avatar Jan 09 '24 07:01 gardener-robot

@sssash18 You need rebase this pull request with latest master branch. Please check.

gardener-robot avatar Jan 29 '24 08:01 gardener-robot

Can this really be merged now ? Latest release gardener uses mcm v0.50.2 (ref). This will add an "unknown field should this be deployed with current gardener and potentially break MCM validation if it is strict. I would hold this until a vendored gardener has a new enough MCM version (like the current master)

/hold

kon-angelo avatar Jan 30 '24 14:01 kon-angelo