etcd-druid icon indicating copy to clipboard operation
etcd-druid copied to clipboard

Upgrade golang version to 1.22.2 and remove dependency on g/g scripts

Open unmarshall opened this issue 10 months ago • 8 comments

How to categorize this PR?

How to categorize this PR?

/area control-plane /kind enhancement

What this PR does / why we need it:

  • Upgrades golang version to 1.22.2
  • Removes dependency on g/g hack/scripts
  • Fixes some flakiness in e2e tests
  • Replace github.com/golang/mock with go.uber.org/mock
  • Upgrade golangci-lint and fix linting errors

Which issue(s) this PR fixes: Fixes #778, #503

Special notes for your reviewer:

Release note:

etcd-druid now uses golang version 1.22.2
`github.com/golang/mock` is replaced by `go.uber.org/mock` since the former is no longer maintained
upgraded golangci-lint to v1.57.2
simplified hack/scripts and removed dependency on g/g hack/scripts

unmarshall avatar Apr 11 '24 17:04 unmarshall

  • make check passes locally
  • make test passes locally
  • make test-integration passes locally
  • make ci-e2e-kind passes locally

unmarshall avatar Apr 11 '24 17:04 unmarshall

/test pull-etcd-druid-e2e-kind

unmarshall avatar Apr 14 '24 15:04 unmarshall

/test pull-etcd-druid-e2e-kind

unmarshall avatar Apr 15 '24 05:04 unmarshall

/retest

renormalize avatar Apr 15 '24 13:04 renormalize

@unmarshall: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-druid-e2e-kind 7ab3c1ea53c12c926224fe10dedf06f3aee777a0 link true /test pull-etcd-druid-e2e-kind
pull-etcd-druid-e2e-kind-nondistroless-etcd 7ab3c1ea53c12c926224fe10dedf06f3aee777a0 link true /test pull-etcd-druid-e2e-kind-nondistroless-etcd

Full PR test history. Your PR dashboard. Command help for this repository. Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

gardener-prow[bot] avatar Apr 15 '24 13:04 gardener-prow[bot]

Will this PR be closed, or will it be rebased on #748?

renormalize avatar Apr 17 '24 04:04 renormalize

i will break this PR into 2: remove g/g scripts and then change go version. This PR will get closed in favor of new PRs.

unmarshall avatar Apr 17 '24 05:04 unmarshall

/hold

#789 solves the go upgrade part of this PR. Will raise another PR after for removing dependency g/g hack scripts, and then close this PR.

shreyas-s-rao avatar Apr 25 '24 16:04 shreyas-s-rao