etcd-druid icon indicating copy to clipboard operation
etcd-druid copied to clipboard

Enable Druid to use mock GCS server to run e2e tests

Open anveshreddy18 opened this issue 1 year ago • 5 comments

How to categorize this PR?

/area dev-productivity /area testing /kind test

What this PR does / why we need it:

This PR enables druid to run e2e tests for GCS locally with the help of a GCS Emulator called fake-gcs-server.

To run e2e tests with GCS Emulator as object store, do make ci-e2e-kind-gcs.

Which issue(s) this PR fixes: Fixes #738

Special notes for your reviewer:

Release note:

Enable Druid to use mock GCS server to run e2e tests using "make ci-e2e-kind-gcs"

anveshreddy18 avatar Jan 01 '24 11:01 anveshreddy18

@anveshreddy18: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-druid-e2e-kind-nondistroless-etcd 917b4b7ede70aeb36a2b13677fe65c22bb3034ad link true /test pull-etcd-druid-e2e-kind-nondistroless-etcd

Full PR test history. Your PR dashboard. Command help for this repository. Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

gardener-prow[bot] avatar Mar 15 '24 14:03 gardener-prow[bot]

@anveshreddy18 You need rebase this pull request with latest master branch. Please check.

gardener-robot avatar Jun 25 '24 12:06 gardener-robot

Thanks for the review @seshachalam-yv, can you pls test now. Earlier there was a hashtag infront of the svcacc.json field in the secret, hence you saw the failure to read the creds. I've now removed that, and updated the docs. Pls follow the latest doc to run it successfully.

anveshreddy18 avatar Jul 16 '24 10:07 anveshreddy18

Could you create a new PR to bump the version of etcd-backup-restore?

seshachalam-yv avatar Jul 16 '24 11:07 seshachalam-yv

/retest

anveshreddy18 avatar Jul 22 '24 06:07 anveshreddy18

/hold

Needs some changes as etcdbr will be modified to depend on mounted secret instead of env vars from druid for endpoint & emulatorEnabled vars. That needs to be accommodated here as well.

anveshreddy18 avatar Jul 29 '24 10:07 anveshreddy18