etcd-backup-restore icon indicating copy to clipboard operation
etcd-backup-restore copied to clipboard

Published 20 hours ago • verified publisher icon gardener

Added insecureSkipVerify and trustedCaCert for AWS S3 implementation …

Open FlorinPeter opened this issue 2 years ago • 4 comments

…in order to allow connections to private MinIO deployments

What this PR does / why we need it: It allow to set insecureSkipVerify or trustedCaCert in order to be able to connect to private MinIO deployments

Release note:

Added ability to use insecureSkipVerify or trustedCaCert for private MinIO deployments

FlorinPeter avatar Jul 21 '22 08:07 FlorinPeter

@FlorinPeter Thank you for your contribution.

gardener-robot avatar Jul 21 '22 08:07 gardener-robot

Thank you @FlorinPeter for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

gardener-robot-ci-3 avatar Jul 21 '22 08:07 gardener-robot-ci-3

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 21 '22 08:07 CLAassistant

@timuthy @ishan16696 I rebased my changes due to the drop of the environment variable handling. Can you please have a look?

FlorinPeter avatar Aug 02 '22 09:08 FlorinPeter

@timuthy @ishan16696 what can I do here to get this PR merged?

FlorinPeter avatar Sep 02 '22 05:09 FlorinPeter

Hi @FlorinPeter , Sorry for the delay, we got busy with other tasks. I will try to review this on priority. Hope that's fine. Thanks

ishan16696 avatar Sep 02 '22 05:09 ishan16696

Can you please also update the example here appropriately.

ishan16696 avatar Sep 02 '22 05:09 ishan16696

@ishan16696 I updated the example, can you tell me why the unit test is failing? I tried to check but concourse is still loading...

FlorinPeter avatar Sep 02 '22 06:09 FlorinPeter

can you tell me why the unit test is failing?

it is due to flaxy tests case, can you please do the re-push as I'm unable to trigger the pipeline tests again.

ishan16696 avatar Sep 02 '22 10:09 ishan16696

@ishan16696 can you add the ok label? I have re-pushed....

FlorinPeter avatar Sep 05 '22 10:09 FlorinPeter

@timuthy @ishan16696 thx for handling it. It looks like the tests have past now successfully ;)

FlorinPeter avatar Sep 06 '22 06:09 FlorinPeter

Hey @FlorinPeter , I have reviewed the PR. LGTM. Can you please rebase this PR on latest master just wanted to tests this PR.

ishan16696 avatar Sep 06 '22 07:09 ishan16696

@ishan16696 done

FlorinPeter avatar Sep 06 '22 07:09 FlorinPeter

I have missed one thing 😐 Can you please also update the doc here for AWS S3 ?

ishan16696 avatar Sep 06 '22 09:09 ishan16696

@ishan16696 sorry for the delay. Can you please have a look if it fits for you?

FlorinPeter avatar Sep 06 '22 15:09 FlorinPeter

@ishan16696 thx a lot for your help!

FlorinPeter avatar Sep 07 '22 03:09 FlorinPeter