etcd-backup-restore icon indicating copy to clipboard operation
etcd-backup-restore copied to clipboard

Adds and fixes small things

Open ishan16696 opened this issue 2 years ago • 4 comments

What this PR does / why we need it:

  1. This commit adds a etcd-config.yaml file. It will be useful in running single member etcd and backup-restore locally for testing purposes. Just have to export ENV: ETCD_CONF=example/00-etcd-config.yaml
  2. This commit set the HTTP status to StatusServiceUnavailable when backup-restore is in StateUnknown.
  3. This commit set the HTTP status to StatusOK when backup-restore is in StateFollower or StateLeader.
  4. This commit removes the wrong snapshot compression time calculation as compression is done in this go routine. so it was more or less calculating pipe creation time. More info: https://pkg.go.dev/io#Pipe
  5. This commit adds small fixes.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Release note:

set the HTTP status to `StatusServiceUnavailable` when backup-restore is in `StateUnknown`.
set the HTTP status to `StatusOK` when backup-restore is in `StateFollower` or `StateLeader`.

ishan16696 avatar Jun 14 '22 14:06 ishan16696

/cla

ishan16696 avatar Jun 30 '22 06:06 ishan16696

@ishan16696 I reached out successfully to the cla-assistant to recheck this pull request.

gardener-robot avatar Jun 30 '22 06:06 gardener-robot

/ping @gardener/etcd-druid-maintainers

ishan16696 avatar Aug 18 '22 20:08 ishan16696

@gardener/etcd-druid-maintainers

Message

/ping @gardener/etcd-druid-maintainers

gardener-robot avatar Aug 18 '22 20:08 gardener-robot

Do we need this PR?

abdasgupta avatar Jan 30 '23 06:01 abdasgupta

@ishan16696 You need rebase this pull request with latest master branch. Please check.

gardener-robot avatar Jul 11 '23 06:07 gardener-robot

closing this PR as PR becomes very old, I will open a separate PR(s) for necessary changes. /close

ishan16696 avatar Aug 10 '23 14:08 ishan16696