dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard

Do not rely on secretRef for ManagedSeed

Open petersutter opened this issue 2 years ago • 2 comments

What this PR does / why we need it: spec.secretRef is not required anymore if Seed is a ManagedSeed

Which issue(s) this PR fixes: Fixes #1308

Special notes for your reviewer:

Release note:

Terminal: `spec.secretRef` is not required anymore if `Seed` is a `ManagedSeed`

petersutter avatar Oct 07 '22 17:10 petersutter

@grolu, @holgerkoser You have pull request review open invite, please check

gardener-robot avatar Oct 13 '22 03:10 gardener-robot

@grolu You have pull request review open invite, please check

gardener-robot avatar Oct 18 '22 03:10 gardener-robot

/hold i need to check if the dashboard clusterrole needs to be adapted for the managedseed get permission as #1283 was merged meanwhile

petersutter avatar Oct 25 '22 17:10 petersutter

/unhold as of https://github.com/gardener/dashboard/pull/1312/commits/3174f6934116ccc919e683e9ed47c5f457438648

petersutter avatar Oct 26 '22 14:10 petersutter