gardenctl
gardenctl copied to clipboard
introduce new packages
Hi all, I want to discuss a generic question about gardenctl packages. Currently there only one global package cmd with a very global scope. What you thinking about to introduce packages like this:
subcmd\
kubectl\
aws\
hermesctl\
It will increase testability, reduce scope, make refactoring simpler, will allow us to use the same packages for testing (currently we use cmd_test and can’t test non-public methods), and as a side effect will let you control our dependencies graph better in terms that gardenctl itself will depend (in the code) on hermesctl but not another way around.
I’m not sure, but I suspect Target
used everywhere and everything depends on it.
In the future, it will let us reuse these submodules independently in other projects?!
Nice proposal, i would suggest we cleanup all existing opening PRs, fix existing bugs (at least bugs we consider critical) in backlog, then we can start this refactor. Let's discuss this in detail in next week planning mtg.