garden icon indicating copy to clipboard operation
garden copied to clipboard

0.13: [Bug]: Logic for parsing Dockerfiles and computing inclusions is missing for action configs

Open vvagaytsev opened this issue 1 year ago • 3 comments

The logic for parsing Dockerfiles and computing the file inclusions from them is only being used for module configs, not action configs. That needs to be fixed.

Current Behavior

Dockerfiles are parsed and processed only when using module configs.

Expected behavior

Dockerfiles should be parsed and processed when using both action and module configs.

Reproducible example

Workaround

None.

Suggested solution(s)

Additional context

See containerHelpers.autoResolveIncludes helper.

Your environment

  • OS:
  • How I'm running Kubernetes:

garden version 0.13.21

vvagaytsev avatar Dec 06 '23 11:12 vvagaytsev

This was discovered while debugging #5317. Thanks, @thsig!

vvagaytsev avatar Dec 06 '23 11:12 vvagaytsev

I seem to recall this being fixed the other day—do you remember, @vvagaytsev?

thsig avatar Feb 14 '24 12:02 thsig

@thsig yes, we still need to fix it. I haven't had a chance to do it so far.

vvagaytsev avatar Feb 14 '24 12:02 vvagaytsev