garden icon indicating copy to clipboard operation
garden copied to clipboard

spec.rules[0].http.paths[0].pathType: Unsupported value: "prefix": supported values: "Exact", "ImplementationSpecific", "Prefix" on Minikube v1.23.0

Open OOPMan opened this issue 4 years ago • 4 comments

Bug

Current Behavior

It seems like the version of K8S used by Minikube v1.23.0 does not like the pathType values being generated by Garden for Ingresses. Specifically, it expects the values to be propercase rather than allowing lowercase values. The version of K8S used by Minikube v1.23.0 is v1.22.1

This is not an issue on Minikube v1.21.0 which uses K8S v1.20.7. I have not tested on Minikube v1.22.0.

This causes deployments to fail with error output of the form:

Failed deploying service 'cim-datastore' (from module 'cim-datastore'). Here is the output:
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Command "/home/cgonsalves/.garden/tools/kubectl/11ac0bbd21058c50/kubectl --context=minikube 
--namespace=opusonesolutions-derms-default apply --prune --selector service=cim-datastore --output=json -f -" failed with code 1:

The Ingress "cim-datastore-0" is invalid: spec.rules[0].http.paths[0].pathType: Unsupported value: "prefix": supported values: 
"Exact", "ImplementationSpecific", "Prefix"

The Ingress "cim-datastore-0" is invalid: spec.rules[0].http.paths[0].pathType: Unsupported value: "prefix": supported values: 
"Exact", "ImplementationSpecific", "Prefix"
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

Failed deploying service 'keycloak' (from module 'keycloak'). Here is the output:
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Command "/home/cgonsalves/.garden/tools/kubectl/11ac0bbd21058c50/kubectl --context=minikube 
--namespace=opusonesolutions-derms-default apply --prune --selector service=keycloak --output=json -f -" failed with code 1:

The Ingress "keycloak-0" is invalid: spec.rules[0].http.paths[0].pathType: Unsupported value: "prefix": supported values: "Exact", 
"ImplementationSpecific", "Prefix"

The Ingress "keycloak-0" is invalid: spec.rules[0].http.paths[0].pathType: Unsupported value: "prefix": supported values: "Exact", 
"ImplementationSpecific", "Prefix"
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

Expected behavior

Expected services to be deployed without issue

Reproducible example

It seems that any basic container service with an ingress declared will suffer this issue on K8S v1.22.1

Workaround

Revert to Minikube v1.21.0 and/or start minikube as follows: minikube start --kubernetes-version=v1.20.7

Suggested solution(s)

Fix K8S manifest generation to propercase the value

Additional context

Your environment

  • OS: Linux
  • How I'm running Kubernetes: Minikube

Garden version 0.12.25

OOPMan avatar Sep 09 '21 15:09 OOPMan

Thanks for the report, this should be a simple fix if using Prefix is backwards compatible.

eysi09 avatar Sep 14 '21 09:09 eysi09

Thanks for the report, this should be a simple fix if using Prefix is backwards compatible.

Hopefully it is. This is a bit of a weird one since the K8S docs all reference it via the propercase form but it seems until recently lowercase worked too and a cursory examination of their changelogs didn't turn up a reference to this change

OOPMan avatar Sep 14 '21 11:09 OOPMan

This issue has been automatically marked as stale because it hasn't had any activity in 90 days. It will be closed in 14 days if no further activity occurs (e.g. changing labels, comments, commits, etc.). Please feel free to tag a maintainer and ask them to remove the label if you think it doesn't apply. Thank you for submitting this issue and helping make Garden a better product!

stale[bot] avatar Jan 03 '22 20:01 stale[bot]

This issue has been automatically marked as stale because it hasn't had any activity in 90 days. It will be closed in 14 days if no further activity occurs (e.g. changing labels, comments, commits, etc.). Please feel free to tag a maintainer and ask them to remove the label if you think it doesn't apply. Thank you for submitting this issue and helping make Garden a better product!

stale[bot] avatar Jul 31 '22 01:07 stale[bot]

@thsig is this still a valid issue? Should we reopen this?

vvagaytsev avatar Oct 06 '22 09:10 vvagaytsev

This issue has been automatically marked as stale because it hasn't had any activity in 90 days. It will be closed in 14 days if no further activity occurs (e.g. changing labels, comments, commits, etc.). Please feel free to tag a maintainer and ask them to remove the label if you think it doesn't apply. Thank you for submitting this issue and helping make Garden a better product!

stale[bot] avatar Jan 07 '23 20:01 stale[bot]

Fixed in #2639

vvagaytsev avatar Jan 19 '23 11:01 vvagaytsev