garden icon indicating copy to clipboard operation
garden copied to clipboard

Deprecate cert-manager integration

Open 10ko opened this issue 3 years ago • 6 comments

Bug

Current Behavior

The current cert-manager version supported in the Garden integration is way too old (v0.11.0) and needs an update.

Expected behavior

As a user I want to be able to generate certificates using the latest version of cert-manager

Reproducible example

N/A

Workaround

You could potentially install cert-manager manually and use it to manage tlsCertificates but we haven't tested with the latest cert-manager version.

Suggested solution(s)

Additional context

Your environment

  • OS:
  • How I'm running Kubernetes:

garden version

10ko avatar Aug 18 '21 22:08 10ko

We've decided to deprecate the cert-manager integration and now recommend that users set up cert-manager separately. What we'd need to do is make sure that's clear in our docs, and to provide some documentation on how to use cert-manager alongside Garden, reference the generated secrets etc.

FYI @MarkMurphy

edvald avatar Aug 27 '21 14:08 edvald

FYI @MarkMurphy

Yeah, just went through that process actually.

MarkMurphy avatar Aug 27 '21 17:08 MarkMurphy

This issue has been automatically marked as stale because it hasn't had any activity in 90 days. It will be closed in 14 days if no further activity occurs (e.g. changing labels, comments, commits, etc.). Please feel free to tag a maintainer and ask them to remove the label if you think it doesn't apply. Thank you for submitting this issue and helping make Garden a better product!

stale[bot] avatar Jan 03 '22 20:01 stale[bot]

Maybe a first step on the path to deprecation would be to fix this:

Failed resolving provider kubernetes. Here is the output:
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Error validating provider configuration: key .certManager.email is required
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Failed resolving one or more providers:
- kubernetes

This happens when you set certManager.install: false

ohookins avatar Feb 14 '22 04:02 ohookins

This issue has been automatically marked as stale because it hasn't had any activity in 90 days. It will be closed in 14 days if no further activity occurs (e.g. changing labels, comments, commits, etc.). Please feel free to tag a maintainer and ask them to remove the label if you think it doesn't apply. Thank you for submitting this issue and helping make Garden a better product!

stale[bot] avatar Jun 12 '22 14:06 stale[bot]

Probably not worth solving if certmanager is going to be removed anyway. Stalebot can close it.

ohookins avatar Jun 13 '22 00:06 ohookins

This issue has been automatically marked as stale because it hasn't had any activity in 90 days. It will be closed in 14 days if no further activity occurs (e.g. changing labels, comments, commits, etc.). Please feel free to tag a maintainer and ask them to remove the label if you think it doesn't apply. Thank you for submitting this issue and helping make Garden a better product!

stale[bot] avatar Jan 07 '23 22:01 stale[bot]

Deprecated in #3517 Fully deleted in #4085 Closing this issue as completed.

Walther avatar Apr 17 '23 14:04 Walther