Patrick Garcia

Results 27 comments of Patrick Garcia

Ah I see you wrote the tests yourself now. Well I dont know anymore then. I think I will leave it to you since it seems I'm only doing everything...

> @garcipat hmm. closing the PR should not have any impact on what was committed; or what previously & currently exists on your fork: > > * https://github.com/garcipat/Bogus/tree/reference-date > >...

> @304NotModified and @garcipat, i think this PR is just about ready. I'm planning on merging it next weekend. > > @garcipat, I pulled in your tests from PR #508...

Hi, I noticed as well that the disk icon is missing. I like the third best because it has a little bit more detail as the other items.

if you change that, can you also fix the License Url? its currenlty pointing to https://github.com/moodmosaic/Fare/blob/master/LICENCE instead of https://raw.githubusercontent.com/moodmosaic/Fare/master/LICENSE

But thats wrong link. this leads to the github file site like you open it to read manually in the repo but not with the raw content. If you want...

Thats completly fine. Just wanted to mention it so it can be fixed for the next release. Thank you