homeassistant_ecowitt
homeassistant_ecowitt copied to clipboard
Migrating to the active PoppyPop fork ?
Hi guys,
Has anyone migrated to the PoppyPop fork that has had a lot of activity ?
I'm more than happy too, but I wanted to know before hand if it might break all my automations ? i.e. Will all the sensor ID's in HA remain the same, or will I need to go through my automations and manually update them to a new set ? (happy to do that but need to make time for it).
Thanks to anyone who can let me know...
I want to jump to this fork to, but how to do this in a proper way is for me not yet clear. I am using the HA docker.
I migrated and the sensor id's change. Some stayed the same others change. So its save to say that you should check automations. Also histories will be broken ofc because its a new sensor.
Thanks for letting us know. I'll be shifting shortly myself. That fork seems to be getting very regular updates.
@garbled1 and @poppypop would be possible that the two of you would try to work together and make a repo which has multiple contributor/owner, so development can be shared between developers?
I would be fine with that, or if someone else would like write to this repo as well.
I'm not against either, we will need to discuss some change that i have made to ensure compatibility with home assistant standard (devcontainer, pre-commit, black, flake8, ...).
In all honesty, I'd much rather the whole thing made it into core. I have a signed dev agreement, so thats not an issue, it's more that the hassle of getting it accepted in is more than I'm willing to deal with. It sounds like you've done most of the fiddlery, so, if the issue is one of my agreement to such, then yes, I whole heartedly agree. I just have zero patience to attempt to get another integration accepted.
Or we can work out an arrangement wrt to the fixes you've mentioned. Either way really. I'm amicable to some changes, I'll look at some diffs later tonight or tomorrow, and give my thoughts, if any.
So I took a quick look at the diffs against your fork. Like you said, most of them are just formatting nits that I didn't bother with because it was alot of work. I didn't see anything however that made me angry, so, I'm pretty sure we could merge the two back into this one, and I could give you write on it I believe.
Or like I said, if you are willing, merge the two together, and then maybe you could try to submit to -core? That would be best for everyone in the long run, but I don't have the stomache to do that again. From my perspective, I just need this code to work, and not break my automations and long term graphs in grafana. :)
@garbled1 I just want to say that I use your integration and I appreciate you taking the time to put it together and potentially collaborate with others about it!
Sorry for the delay, I am in the same mood for submitting to the -core, it's a lot of work and a huge investment. I will look to make a clean PR today or tomorrow.
Hey all, has this progressed @PoppyPop ? or is there some instruction on how to install your fork? as the HACS guide just installs this one which doesn't work with the latest HA. Thanks.
as the HACS guide just installs this one which doesn't work with the latest HA. Thanks.
Can you open an another issue if there is any problem with this custom component and HA 2021.11.X?
Otherwise, what is exactly your problem, why it doesn't work?,
@GSzabados for a few iterations of HA, this component has not worked for me. It just says unavailable for all the sensors. Its connected to Wu underground and working well through that. But since an update to core 9xx(?) onwards it hasn't worked. Nothing much in the logs either.
But since an update to core 9xx(?) onwards it hasn't worked. Nothing much in the logs either.
Ok, open a new issue and let's continue the conversation there. I will give some debugging guides/ideas there.
(I have 2021.10.6 running currently and I haven't got any issues with this integration. All works fine.)
Just a note on this, Most likely in the next few weeks I'm going to start the effort to get ecowitt into base HA, I want to finish up getting balboa in there first.