homeassistant_ecowitt icon indicating copy to clipboard operation
homeassistant_ecowitt copied to clipboard

Sensor Entity Names should be prefixed by device name

Open splitbrain opened this issue 3 years ago • 7 comments

When adding the integration, the device name can be configured. However the sensor names are simply added as sensor.daily_rain_rate it would be nice if they were automatically prefixed with the device name, eg. sensor.ecowitt_daily_rain_rate.

Alternatively an optional entity prefix with an empty default might be a good way to add this in a backward compatible way.

(currently using the fork by @PoppyPop until this repo has been fixed)

splitbrain avatar Aug 10 '21 18:08 splitbrain

Hi, i checked the home assistant docs for the best practice, do you have some example ? I checked, my production environnement and i have only 1 prefixed integration (OpenWeatherMap)

I someone knows an official guideline on sensor name, feel free to comment with a link

PoppyPop avatar Aug 20 '21 15:08 PoppyPop

The Fronius integration also does that, and it's very useful with a filter card fronius I can have all of the sensors displayed. When the integration changed names and added sensors, they were still displayed. Also it could be quite common to have a sensor.humidity or generic names like that. Don't know about official guidelines or so, but the change would be much appreciated. Of course it's something that has to be pondered, because it would break sensors historyhj

tigers75 avatar Jan 12 '22 21:01 tigers75

I agree with tigers75, it would help a lot to anyone setting up cards etc. I know it made it harder for me not having it prefixed. I'm not fussed about breaking the history data as I only store a month.

mr-sneezy avatar Jan 13 '22 09:01 mr-sneezy

Yesss !! Exactly !! I have many temperature sensors ... and one ugly example from ecowitt is: sensor.temperature_1 :( I would REALLY appreciate something like sensor.ecowitt_* as entity name (or, if there is any issue/concern, at least to be able to seelct this option during configuration :-) )

adynis avatar Aug 21 '22 22:08 adynis

hi all, are you aware a new version of the core is release including the ECOWITT integration?

now it does not provide the prefix but all sensors appear to be working fine with this new release https://www.home-assistant.io/integrations/ecowitt

maybe we should reconvene in the main support fora?

DoerakkerHA avatar Sep 14 '22 06:09 DoerakkerHA

I tired to install the official integration but didn't work for me. Also on the github I see there're some problems to resolve so, I'm waiting for the moment.

tigers75 avatar Sep 14 '22 06:09 tigers75

There was a problem with the .0 release which meant it didn’t work at all (at least for me), but that was resolved in .1. There seems to be a smaller bug fix in .2 that was just released, but mines been working fine since .1.

On Wed, Sep 14, 2022, at 2:34 PM, tigers75 wrote:

I tired to install the official integration but didn't work for me. Also on the github I see there're some problems to resolve so, I'm waiting for the moment.

— Reply to this email directly, view it on GitHub https://github.com/garbled1/homeassistant_ecowitt/issues/75#issuecomment-1246306292, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAF2YVEWURWLP72K6IHU7UDV6FWXVANCNFSM5B4UH57Q. You are receiving this because you are subscribed to this thread.Message ID: @.***>

sam-ward avatar Sep 14 '22 06:09 sam-ward