Garrett Brown

No major issues from what I can see. Cool feature!

Sometimes when you force push, jenkins gets confused and errs when pulling the new version. You can see win32 and freebsd had problems with the force push this time: https://jenkins.kodi.tv/job/BuildMulti-PR/23437/...

I'll do a thorough review when the PR is marked as ready status. I really like this feature though. Question, how do you scrape the movie edition? My current approaches...

In a library of 1626 movies, these are the 115 marked editions I have: ``` [30th Anniversary Edition] [35mm Edition Blu-ray Disc] [35mm Edition] [3D Diamond Edition] [3D Extended Cut]...

You make a good point. The first thing is to gather all existing standards for editions. Then we choose the one that makes the most sense, or define our own....

I think ksooo found everything I would have commented on. Everything else looks good. 577 lines added, 20 lines deleted indicates that the feature was probably added nice and clean....

Why have a dynamic version for GCC? Surely the static version is more memory-friendly by avoiding the heap? Also we probably don't want behavior to change if someone just flips...

Minor version bump is perfect. thanks!

If it fixes https://github.com/Pulse-Eight/libcec/issues/567 then I'm in support of this change.

I think we're ready to go, I just leave comments to make the lives of heroic translators slightly better