Garrett Brown

@fbacher Good progress so far, Kodi's depends system is a massive beast and it's encouraging seeing someone take the challenge head-on. I'm less sure from a technical standpoint, but from...

Nice job getting it to build. Yes, you should create/modify the Makefile in `tools/depends`. It can probably just call into CMake. Our depends system is used on all embedded platforms,...

You probably have a mobile phone that supports Kodi, both android and ios use depends. macOS uses a depends build too. Jenkins only builds depends when they change, and rebuilding...

The design allows CThread to be constructed with an "autodelete" feature, which allows for "new and forget me" type construction. In this mode, `new` is called but the return value...

> This issue is specific to StopThread(), I don't think that autodelete is affected by this change. The issue is that StopThread() behavior now depends on autodelete (because the destiny...

My advice: remove autodelete. Nothing short of this will clean the santizer errors. Use refcounting or make a manager that tracks autodeleting threads.

The change quiets the sanitizers, but they wouldn't see the double free for the same reason they didn't see the single free. Have you runtime tested this change? Can you...

There's multiple factors to weight, from a safety standpoint I don't see much cost and those who would benefit is clearly a gain. Seems like it'd be more of a...

Mergeable fixed. @fbacher It looks like you're bringing in a new dependency. As someone who's added a dependency (flatbuffers) I can relay that it's a long process, because we cover...

BTW, found your msg hard to read because GH collapses <> (very annoying). You can replace all < with `<` and it'll look normal.