Scoreboard doesn't show to spectators who joined via /ma s

[molor]

Bug report

(self-explanatory)

Reproduction steps

1. Join an already running arena with /ma s
2. See that there is no scoreboard on right side

But if player died while playing on arena, scoreboard will still be displayed and updated after they respawned and moved to spectate area.

Details

• MobArena version: https://github.com/garbagemule/MobArena/actions/runs/1835158985
• Server version: Paper 1.18.1

[Nesseley]

I don't really count this as a bug... The player who died participated in the arena and have a kill-count from before they died. The spectator is just visiting and watching.

[molor]

Our admins, for example, sometimes wonder about this (e.g. who killed how many mobs) to detect cheaters or suspicious players, while they are not in the arena. But they can't see that :с

[garbagemule]

The scoreboards were added mostly as a way to combat the issue of arena players not being able to see the leaderboard signs, which were visible to everyone else, including spectators who didn't actually participate in the arena session. Perhaps setting up leaderboard signs could be a good workaround for now.

I don't see this happening any time soon. Scoreboards are a nightmare to work with, and the current implementation is already a huge mess. I'd rather not touch it, but if anyone wants to take a stab at a PR, I'll be more than happy to review it.